Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: remoting/webapp/base/js/client_session.js

Issue 1131853004: Include the session id in feedback logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer feedback. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/webapp/app_remoting/js/feedback_consent.js ('k') | remoting/webapp/base/js/log_to_server.js » ('j') | remoting/webapp/base/js/log_to_server.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Class handling creation and teardown of a remoting client session. 7 * Class handling creation and teardown of a remoting client session.
8 * 8 *
9 * The ClientSession class controls lifetime of the client plugin 9 * The ClientSession class controls lifetime of the client plugin
10 * object and provides the plugin with the functionality it needs to 10 * object and provides the plugin with the functionality it needs to
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 /** 596 /**
597 * Enable or disable logging of connection errors due to a host being offline. 597 * Enable or disable logging of connection errors due to a host being offline.
598 * For example, if attempting a connection using a cached JID, host-offline 598 * For example, if attempting a connection using a cached JID, host-offline
599 * errors should not be logged because the JID will be refreshed and the 599 * errors should not be logged because the JID will be refreshed and the
600 * connection retried. 600 * connection retried.
601 * 601 *
602 * @param {boolean} enable True to log host-offline errors; false to suppress. 602 * @param {boolean} enable True to log host-offline errors; false to suppress.
603 */ 603 */
604 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) { 604 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
605 this.logHostOfflineErrors_ = enable; 605 this.logHostOfflineErrors_ = enable;
606 }; 606 };
kelvinp 2015/05/14 21:54:57 Unintended removal of blank line
Jamie 2015/05/15 00:26:22 It was unintended (I think Emacs cleans up this so
607
OLDNEW
« no previous file with comments | « remoting/webapp/app_remoting/js/feedback_consent.js ('k') | remoting/webapp/base/js/log_to_server.js » ('j') | remoting/webapp/base/js/log_to_server.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698