Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: remoting/webapp/base/js/client_session.js

Issue 1131853004: Include the session id in feedback logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Class handling creation and teardown of a remoting client session. 7 * Class handling creation and teardown of a remoting client session.
8 * 8 *
9 * The ClientSession class controls lifetime of the client plugin 9 * The ClientSession class controls lifetime of the client plugin
10 * object and provides the plugin with the functionality it needs to 10 * object and provides the plugin with the functionality it needs to
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 }; 322 };
323 323
324 /** 324 /**
325 * @return {!remoting.Error} The current error code. 325 * @return {!remoting.Error} The current error code.
326 */ 326 */
327 remoting.ClientSession.prototype.getError = function() { 327 remoting.ClientSession.prototype.getError = function() {
328 return this.error_; 328 return this.error_;
329 }; 329 };
330 330
331 /** 331 /**
332 * @return {string} The current session id. This is random GUID, refreshed
333 * every 24hrs.
334 */
335 remoting.ClientSession.prototype.getSessionId = function() {
336 return this.logToServer_.getSessionId();
kelvinp 2015/05/13 22:36:53 use this.sessionId_ instead.
Jamie 2015/05/13 23:41:24 I hadn't realized there was already a sessionId_ m
kelvinp 2015/05/14 01:18:04 On I see, in this, case, you can access the logger
337 };
338
339 /**
332 * Called when the client receives its first frame. 340 * Called when the client receives its first frame.
333 * 341 *
334 * @return {void} Nothing. 342 * @return {void} Nothing.
335 */ 343 */
336 remoting.ClientSession.prototype.onFirstFrameReceived = function() { 344 remoting.ClientSession.prototype.onFirstFrameReceived = function() {
337 this.hasReceivedFrame_ = true; 345 this.hasReceivedFrame_ = true;
338 }; 346 };
339 347
340 /** 348 /**
341 * @return {boolean} Whether the client has received a video buffer. 349 * @return {boolean} Whether the client has received a video buffer.
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 * Enable or disable logging of connection errors due to a host being offline. 605 * Enable or disable logging of connection errors due to a host being offline.
598 * For example, if attempting a connection using a cached JID, host-offline 606 * For example, if attempting a connection using a cached JID, host-offline
599 * errors should not be logged because the JID will be refreshed and the 607 * errors should not be logged because the JID will be refreshed and the
600 * connection retried. 608 * connection retried.
601 * 609 *
602 * @param {boolean} enable True to log host-offline errors; false to suppress. 610 * @param {boolean} enable True to log host-offline errors; false to suppress.
603 */ 611 */
604 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) { 612 remoting.ClientSession.prototype.logHostOfflineErrors = function(enable) {
605 this.logHostOfflineErrors_ = enable; 613 this.logHostOfflineErrors_ = enable;
606 }; 614 };
607
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698