Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1131853002: [turbofan] Extract frame-states.h from common-operator.h (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extract frame-states.h from common-operator.h R=jarin@chromium.org BUG= Committed: https://crrev.com/256ae73652d68604218d1c7a6eab88a57a184fce Cr-Commit-Position: refs/heads/master@{#28330}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -138 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +2 lines, -97 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +0 lines, -41 lines 0 comments Download
A src/compiler/frame-states.h View 1 chunk +116 lines, -0 lines 0 comments Download
A src/compiler/frame-states.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 7 months ago (2015-05-07 08:56:21 UTC) #1
Jarin
lgtm
5 years, 7 months ago (2015-05-07 09:52:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131853002/20001
5 years, 7 months ago (2015-05-11 07:16:57 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 08:03:09 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 08:03:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/256ae73652d68604218d1c7a6eab88a57a184fce
Cr-Commit-Position: refs/heads/master@{#28330}

Powered by Google App Engine
This is Rietveld 408576698