Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1131813004: Revert of Create net::FormatOriginForDisplay helper function. (Closed)

Created:
5 years, 7 months ago by palmer
Modified:
5 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create net::FormatOriginForDisplay helper function. (patchset #8 id:140001 of https://codereview.chromium.org/1133943002/) Reason for revert: This CL needs more work, and potentially to be moved to a new module. Original issue's description: > Create net::FormatOriginForDisplay helper function. > > net::FormatOriginForDisplay provides a canonical, concise, human-friendly > display for origins. It supports callers in any higher-layer module. > > Based heavily on earlier work by dewittj and felt. Thanks! > > BUG=402698 > TBR=thakis,brettw TBR=asanka@chromium.org,dewittj@chromium.org,felt@chromium.org,rsleevi@chromium.org,thakis@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=402698 Committed: https://crrev.com/45750ba150e44d7c3b978d3966a2e3949c50bef4 Cr-Commit-Position: refs/heads/master@{#330269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -258 lines) Patch
M base/strings/utf_string_conversions.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/base/net_util.h View 5 chunks +7 lines, -27 lines 0 comments Download
M net/base/net_util_icu.cc View 2 chunks +1 line, -43 lines 0 comments Download
M net/base/net_util_icu_unittest.cc View 2 chunks +0 lines, -179 lines 0 comments Download
M url/gurl.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palmer
Created Revert of Create net::FormatOriginForDisplay helper function.
5 years, 7 months ago (2015-05-16 02:09:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131813004/1
5 years, 7 months ago (2015-05-16 02:09:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 02:11:02 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45750ba150e44d7c3b978d3966a2e3949c50bef4
Cr-Commit-Position: refs/heads/master@{#330269}

Powered by Google App Engine
This is Rietveld 408576698