Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: runtime/vm/raw_object.cc

Issue 11318018: - Represent strings internally in UTF-16 format, this makes it (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/raw_object.cc
===================================================================
--- runtime/vm/raw_object.cc (revision 14314)
+++ runtime/vm/raw_object.cc (working copy)
@@ -101,13 +101,6 @@
instance_size = TwoByteString::InstanceSize(string_length);
break;
}
- case kFourByteStringCid: {
- const RawFourByteString* raw_string =
- reinterpret_cast<const RawFourByteString*>(this);
- intptr_t string_length = Smi::Value(raw_string->ptr()->length_);
- instance_size = FourByteString::InstanceSize(string_length);
- break;
- }
case kArrayCid:
case kImmutableArrayCid: {
const RawArray* raw_array = reinterpret_cast<const RawArray*>(this);
@@ -688,14 +681,6 @@
}
-intptr_t RawFourByteString::VisitFourByteStringPointers(
- RawFourByteString* raw_obj, ObjectPointerVisitor* visitor) {
- intptr_t length = Smi::Value(raw_obj->ptr()->length_);
- visitor->VisitPointers(raw_obj->from(), raw_obj->to());
- return FourByteString::InstanceSize(length);
-}
-
-
intptr_t RawExternalOneByteString::VisitExternalOneByteStringPointers(
RawExternalOneByteString* raw_obj, ObjectPointerVisitor* visitor) {
// Make sure that we got here with the tagged pointer as this.
@@ -714,15 +699,6 @@
}
-intptr_t RawExternalFourByteString::VisitExternalFourByteStringPointers(
- RawExternalFourByteString* raw_obj, ObjectPointerVisitor* visitor) {
- // Make sure that we got here with the tagged pointer as this.
- ASSERT(raw_obj->IsHeapObject());
- visitor->VisitPointers(raw_obj->from(), raw_obj->to());
- return ExternalFourByteString::InstanceSize();
-}
-
-
intptr_t RawBool::VisitBoolPointers(RawBool* raw_obj,
ObjectPointerVisitor* visitor) {
// Make sure that we got here with the tagged pointer as this.

Powered by Google App Engine
This is Rietveld 408576698