runtime/bin/file.cc - Issue 11318018: - Represent strings internally in UTF-16 format, this makes it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file.cc

Issue 11318018: - Represent strings internally in UTF-16 format, this makes it (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file.cc

===================================================================

--- runtime/bin/file.cc (revision 14314)

+++ runtime/bin/file.cc (working copy)

@@ -411,7 +411,7 @@

char* path = File::GetContainingDirectory(str_copy);

free(str_copy);

if (path != NULL) {

- Dart_SetReturnValue(args, Dart_NewString(path));

+ Dart_SetReturnValue(args, DartUtils::NewString(path));

free(path);

} else {

Dart_Handle err = DartUtils::NewDartOSError();

@@ -428,7 +428,7 @@

DartUtils::GetStringValue(Dart_GetNativeArgument(args, 0));

char* path = File::GetCanonicalPath(str);