- Represent strings internally in UTF-16 format, this makes it

runtime/vm/debugger_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "platform/assert.h"
 #include "vm/dart_api_impl.h"
 #include "vm/thread.h"
 #include "vm/unit_test.h"
 
@@ skipping 13 matching lines @@
   EXPECT_VALID(script_lib);
 }
 
 
 static void SetBreakpointAtEntry(const char* cname, const char* fname) {
   ASSERT(script_lib != NULL);
   ASSERT(!Dart_IsError(script_lib));
   ASSERT(Dart_IsLibrary(script_lib));
   Dart_Breakpoint bpt;
   Dart_Handle res = Dart_SetBreakpointAtEntry(script_lib,
-                        Dart_NewString(cname),
-                        Dart_NewString(fname),
+                        NewString(cname),
+                        NewString(fname),
                         &bpt);
   EXPECT_VALID(res);
 }
 
 
 static Dart_Handle Invoke(const char* func_name) {
   ASSERT(script_lib != NULL);
   ASSERT(!Dart_IsError(script_lib));
   ASSERT(Dart_IsLibrary(script_lib));
-  return Dart_Invoke(script_lib, Dart_NewString(func_name), 0, NULL);
+  return Dart_Invoke(script_lib, NewString(func_name), 0, NULL);
 }
 
 
 static char const* ToCString(Dart_Handle str) {
   EXPECT(Dart_IsString(str));
   char const* c_str = NULL;
   Dart_StringToCString(str, &c_str);
   return c_str;
 }
 
@@ skipping 569 matching lines @@
   EXPECT_EQ(442, int_value);
   EXPECT_EQ(2, breakpoint_hit_counter);
 }
 
 
 static void ExprClosureBreakpointHandler(Dart_IsolateId isolate_id,
                                          Dart_Breakpoint bpt,
                                          Dart_StackTrace trace) {
   static const char* expected_trace[] = {"add", "main"};
   Dart_Handle add_locals = Dart_NewList(4);
-  Dart_ListSetAt(add_locals, 0, Dart_NewString("a"));
+  Dart_ListSetAt(add_locals, 0, NewString("a"));
   Dart_ListSetAt(add_locals, 1, Dart_NewInteger(10));
-  Dart_ListSetAt(add_locals, 2, Dart_NewString("b"));
+  Dart_ListSetAt(add_locals, 2, NewString("b"));
   Dart_ListSetAt(add_locals, 3, Dart_NewInteger(20));
   Dart_Handle expected_locals[] = {add_locals, Dart_Null()};
   breakpoint_hit_counter++;
   PrintStackTrace(trace);
   VerifyStackTrace(trace, expected_trace, expected_locals, 2);
 }
 
 
 TEST_CASE(Debug_ExprClosureBreakpoint) {
   const char* kScriptChars =
       "var c;                 \n"
       "                       \n"
       "main() {               \n"
       "  c = add(a, b) {      \n"
       "    return a + b;      \n"
       "  };                   \n"
       "  return c(10, 20);    \n"
       "}                      \n";
 
   LoadScript(kScriptChars);
   Dart_SetBreakpointHandler(&ExprClosureBreakpointHandler);
 
-  Dart_Handle script_url = Dart_NewString(TestCase::url());
+  Dart_Handle script_url = NewString(TestCase::url());
   intptr_t line_no = 5;  // In closure 'add'.
   Dart_Handle res = Dart_SetBreakpoint(script_url, line_no);
   EXPECT_VALID(res);
   EXPECT(Dart_IsInteger(res));
 
   breakpoint_hit_counter = 0;
   Dart_Handle retval = Invoke("main");
   EXPECT_VALID(retval);
   int64_t int_value = 0;
   Dart_IntegerToInt64(retval, &int_value);
@@ skipping 45 matching lines @@
       "}                      \n"
       "                       \n"
       "void main() {          \n"
       "  foo();               \n"
       "  foo();               \n"
       "  foo();               \n"
       "}                      \n";
 
   LoadScript(kScriptChars);
 
-  Dart_Handle script_url = Dart_NewString(TestCase::url());
+  Dart_Handle script_url = NewString(TestCase::url());
   intptr_t line_no = 4;  // In function 'foo'.
 
   Dart_SetBreakpointHandler(&DeleteBreakpointHandler);
 
   Dart_Handle res = Dart_SetBreakpoint(script_url, line_no);
   EXPECT_VALID(res);
   EXPECT(Dart_IsInteger(res));
   int64_t bp_id = 0;
   Dart_IntegerToInt64(res, &bp_id);
 
   // Function main() calls foo() 3 times. On the second iteration, the
   // breakpoint is removed by the handler, so we expect the breakpoint
   // to fire twice only.
   bp_id_to_be_deleted = bp_id;
   breakpoint_hit_counter = 0;
   Dart_Handle retval = Invoke("main");
   EXPECT_VALID(retval);
   EXPECT_EQ(2, breakpoint_hit_counter);
 }
 
 
 static void InspectStaticFieldHandler(Dart_IsolateId isolate_id,
                                       Dart_Breakpoint bpt,
                                       Dart_StackTrace trace) {
   ASSERT(script_lib != NULL);
   ASSERT(!Dart_IsError(script_lib));
   ASSERT(Dart_IsLibrary(script_lib));
-  Dart_Handle class_A = Dart_GetClass(script_lib, Dart_NewString("A"));
+  Dart_Handle class_A = Dart_GetClass(script_lib, NewString("A"));
   EXPECT_VALID(class_A);
 
   const int expected_num_fields = 2;
   struct {
     const char* field_name;
     const char* field_value;
   } expected[] = {
     // Expected values at first breakpoint.
     { "bla", "yada yada yada"},
     { "u", "null" },
@@ skipping 243 matching lines @@
     Dart_ListLength(scripts, &num_scripts);
     EXPECT(num_scripts >= 0);
     for (int i = 0; i < num_scripts; i++) {
       Dart_Handle script_url = Dart_ListGetAt(scripts, i);
       char const* chars;
       Dart_StringToCString(script_url, &chars);
       OS::Print("  script %d: '%s'\n", i + 1, chars);
     }
   }
 
-  Dart_Handle lib_url = Dart_NewString(TestCase::url());
+  Dart_Handle lib_url = NewString(TestCase::url());
   Dart_Handle source = Dart_GetScriptSource(lib_url, lib_url);
   EXPECT(Dart_IsString(source));
   char const* source_chars;
   Dart_StringToCString(source, &source_chars);
   OS::Print("\n=== source: ===\n%s", source_chars);
   EXPECT_STREQ(kScriptChars, source_chars);
 }
 
 
 TEST_CASE(GetLibraryURLs) {
   const char* kScriptChars =
       "main() {"
       "  return 12345;"
       "}";
 
   Dart_Handle lib_list = Dart_GetLibraryURLs();
   EXPECT_VALID(lib_list);
   EXPECT(Dart_IsList(lib_list));
   Dart_Handle list_as_string = Dart_ToString(lib_list);
   const char* list_cstr = "";
   EXPECT_VALID(Dart_StringToCString(list_as_string, &list_cstr));
   EXPECT_NOTSUBSTRING(TestCase::url(), list_cstr);
 
   // Load a script.
-  Dart_Handle url = Dart_NewString(TestCase::url());
-  Dart_Handle source = Dart_NewString(kScriptChars);
+  Dart_Handle url = NewString(TestCase::url());
+  Dart_Handle source = NewString(kScriptChars);
   EXPECT_VALID(Dart_LoadScript(url, source));
 
   lib_list = Dart_GetLibraryURLs();
   EXPECT_VALID(lib_list);
   EXPECT(Dart_IsList(lib_list));
   list_as_string = Dart_ToString(lib_list);
   list_cstr = "";
   EXPECT_VALID(Dart_StringToCString(list_as_string, &list_cstr));
   EXPECT_SUBSTRING(TestCase::url(), list_cstr);
 }
@@ skipping 165 matching lines @@
     while (interrupt_isolate_id != ILLEGAL_ISOLATE_ID) {
       ml.Wait();
     }
   }
   EXPECT(interrupt_isolate_id == ILLEGAL_ISOLATE_ID);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart