Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1131793011: Remove the extra guard in InstanceIDProfileService (Closed)

Created:
5 years, 7 months ago by jianli
Modified:
5 years, 7 months ago
Reviewers:
Nico, fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the extra guard in InstanceIDProfileService This is not longer needed since we only guard the API under _api_features. This extra guard is causing the test failures in officla builds since extensions::ScopedCurrentChannel does not affect the regular chrome channel settings. BUG=489368 TEST=existing tests Committed: https://crrev.com/b5dd6d281e4f1209063594e0c96b3279591bfc4e Cr-Commit-Position: refs/heads/master@{#330572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M chrome/browser/extensions/api/instance_id/instance_id_apitest.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/services/gcm/instance_id/instance_id_profile_service.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fgorski
lgtm
5 years, 7 months ago (2015-05-19 14:05:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131793011/1
5 years, 7 months ago (2015-05-19 18:36:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 18:40:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5dd6d281e4f1209063594e0c96b3279591bfc4e Cr-Commit-Position: refs/heads/master@{#330572}
5 years, 7 months ago (2015-05-19 18:41:30 UTC) #6
Nico
5 years, 7 months ago (2015-05-20 00:17:59 UTC) #8
Message was sent while issue was closed.
Looks like this also fixed browser_tests in buildtype=Official. Thanks! :-)

Powered by Google App Engine
This is Rietveld 408576698