Forced style invalidation when clearing resolver no longer needed.

Forced style invalidation when clearing resolver no longer needed.

When the StyleInvalidator was stored on the RuleFeatureSet, we had to
invalidate with pending invalidations before clearing the RuleFeatureSets
as part of clearing the StyleResolver. After the StyleInvalidator was
moved to StyleEngine, this is no longer necessary as invalidation sets
are reference counted and can be used by the invalidator after their
stylesheets are nuked.

TEST=fast/css/invalidation/style-update-with-added-stylesheet.html

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=401359
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195407

[esprehn, 2015-05-13 01:19:14]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2015-05-13 01:19:15]

lgtm

Amazing!

[commit-bot: I haz the power, 2015-05-13 01:19:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793008/1

[commit-bot: I haz the power, 2015-05-13 03:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 03:27:14]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[rune, 2015-05-13 08:59:11]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2015-05-13 08:59:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793008/1

[commit-bot: I haz the power, 2015-05-13 11:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 11:11:16]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[rune, 2015-05-14 21:27:48]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2015-05-14 21:28:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793008/1

[commit-bot: I haz the power, 2015-05-14 23:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 23:38:55]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/62767)

[esprehn, 2015-05-14 23:44:02]

It doesn't seem this works.

[rune, 2015-05-15 06:56:13]

On 2015/05/14 23:44:02, esprehn wrote:
> It doesn't seem this works.

Yeah. I don't get the fails locally, but this seems consistent on the bots.

[rune, 2015-05-15 12:56:06]

On 2015/05/15 06:56:13, rune wrote:
> On 2015/05/14 23:44:02, esprehn wrote:
> > It doesn't seem this works.
> 
> Yeah. I don't get the fails locally, but this seems consistent on the bots.

ASSERT(styleResolver()) in Document::updateStyleInvalidationIfNeeded() is
obviously not true anymore as we may have pending invalidations after a resolver
clear. I'll just remove the assert, the resolver will be re-created on demand.

[rune, 2015-05-15 12:56:51]

On 2015/05/15 12:56:06, rune wrote:
> On 2015/05/15 06:56:13, rune wrote:
> > On 2015/05/14 23:44:02, esprehn wrote:
> > > It doesn't seem this works.
> > 
> > Yeah. I don't get the fails locally, but this seems consistent on the bots.
> 
> ASSERT(styleResolver()) in Document::updateStyleInvalidationIfNeeded() is

I couldn't reproduce it locally because my local release build doesn't have
asserts enabled.

[rune, 2015-05-15 13:10:44]

The CQ bit was checked by rune@opera.com

[rune, 2015-05-15 13:10:44]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1131793008/#ps20001
(title: "Removed no longer valid styleResolver() assert.")

[commit-bot: I haz the power, 2015-05-15 13:10:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793008/20001

[commit-bot: I haz the power, 2015-05-15 14:17:31]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195407