Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java

Issue 1131793004: Migrate AudioFocusChangeListener to browser and always send GAIN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: webview suggestions from boliu Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
index 6168e45abbe7d9f9e08799dd16626e4e0da4fdfa..00d53cbace12e2ab4eb925bd1d2ee217a569e2d5 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java
@@ -193,7 +193,9 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
assertTrue(DOMUtils.isVideoPaused(getWebContentsOnUiThread(), VIDEO_ID));
tapPlayButton();
- assertTrue(DOMUtils.waitForVideoPlay(getWebContentsOnUiThread(), VIDEO_ID));
+ assertTrue(DOMUtils.waitForVideoState(getWebContentsOnUiThread(),
+ VIDEO_ID,
+ DOMUtils.VIDEO_STATE_PLAYING));
}
@MediumTest
@@ -206,7 +208,9 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
// Play and verify that a surface view for hole punching is not created.
// Note that VIDEO_TEST_URL contains clear video.
tapPlayButton();
- assertTrue(DOMUtils.waitForVideoPlay(getWebContentsOnUiThread(), VIDEO_ID));
+ assertTrue(DOMUtils.waitForVideoState(getWebContentsOnUiThread(),
+ VIDEO_ID,
+ DOMUtils.VIDEO_STATE_PLAYING));
// Wait to ensure that the surface view is not added asynchronously.
VideoSurfaceViewUtils.waitAndAssertContainsZeroVideoHoleSurfaceViews(this,
mTestContainerView);
@@ -228,7 +232,9 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
// Play and verify that there is a surface view for hole punching.
tapPlayButton();
- assertTrue(DOMUtils.waitForVideoPlay(getWebContentsOnUiThread(), VIDEO_ID));
+ assertTrue(DOMUtils.waitForVideoState(getWebContentsOnUiThread(),
+ VIDEO_ID,
+ DOMUtils.VIDEO_STATE_PLAYING));
VideoSurfaceViewUtils.pollAndAssertContainsOneVideoHoleSurfaceView(this,
mTestContainerView);
@@ -262,7 +268,9 @@ public class AwContentsClientFullScreenTest extends AwTestBase {
// Play and verify that there is a surface view for hole punching.
tapPlayButton();
- assertTrue(DOMUtils.waitForVideoPlay(getWebContentsOnUiThread(), VIDEO_ID));
+ assertTrue(DOMUtils.waitForVideoState(getWebContentsOnUiThread(),
+ VIDEO_ID,
+ DOMUtils.VIDEO_STATE_PLAYING));
VideoSurfaceViewUtils.pollAndAssertContainsOneVideoHoleSurfaceView(this,
mTestContainerView);
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698