Upgrade checkbox, pref-tracker, and prefs to 0.8

Upgrade checkbox, pref-tracker, and prefs to 0.8

BUG=485381
Committed: https://crrev.com/6382609b0412bacd5fc8a719f01bef4927e96287
Cr-Commit-Position: refs/heads/master@{#328713}

[Jeremy Klein, 2015-05-07 00:42:56]

jlklein@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Jeremy Klein, 2015-05-07 00:42:56]

This will break md-settings intentionally. Let's get the ball rollin!

[Kyle Horimoto, 2015-05-07 02:11:21]

lgtm

LGTM w/ a question

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/checkbox/checkbox.js (right):

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/checkbox/checkbox.js:21: * The boolean
preference object to control.
question: Are we no longer annotating fields with JSDoc in 0.8?

[Jeremy Klein, 2015-05-07 02:15:22]

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/checkbox/checkbox.js (right):

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/checkbox/checkbox.js:21: * The boolean
preference object to control.
On 2015/05/07 02:11:21, Kyle Horimoto wrote:
> question: Are we no longer annotating fields with JSDoc in 0.8?

We only need to annotate more specific types for arrays and Objects. The Polymer
compiler pass can pick up primitive types from the polymer syntax here. In this
case, we should probably be using the PrefObject type from the cettingsPrivate
externs. Right now, we seem to have just been using "Object". If you want, I can
track down those externs and use them here. Might need some casts elsewhere, but
not sure...

[Kyle Horimoto, 2015-05-07 02:20:00]

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/checkbox/checkbox.js (right):

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/checkbox/checkbox.js:21: * The boolean
preference object to control.
On 2015/05/07 02:15:22, Jeremy Klein wrote:
> On 2015/05/07 02:11:21, Kyle Horimoto wrote:
> > question: Are we no longer annotating fields with JSDoc in 0.8?
> 
> We only need to annotate more specific types for arrays and Objects. The
Polymer
> compiler pass can pick up primitive types from the polymer syntax here. In
this
> case, we should probably be using the PrefObject type from the cettingsPrivate
> externs. Right now, we seem to have just been using "Object". If you want, I
can
> track down those externs and use them here. Might need some casts elsewhere,
but
> not sure...

Hmm, might be better to annotate it as such for clarity, even though we aren't
actually compiling it yet.

[Jeremy Klein, 2015-05-07 03:12:19]

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/checkbox/checkbox.js (right):

https://codereview.chromium.org/1131793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/checkbox/checkbox.js:21: * The boolean
preference object to control.
On 2015/05/07 02:20:00, Kyle Horimoto wrote:
> On 2015/05/07 02:15:22, Jeremy Klein wrote:
> > On 2015/05/07 02:11:21, Kyle Horimoto wrote:
> > > question: Are we no longer annotating fields with JSDoc in 0.8?
> > 
> > We only need to annotate more specific types for arrays and Objects. The
> Polymer
> > compiler pass can pick up primitive types from the polymer syntax here. In
> this
> > case, we should probably be using the PrefObject type from the
cettingsPrivate
> > externs. Right now, we seem to have just been using "Object". If you want, I
> can
> > track down those externs and use them here. Might need some casts elsewhere,
> but
> > not sure...
> 
> Hmm, might be better to annotate it as such for clarity, even though we aren't
> actually compiling it yet.

Done.

[Jeremy Klein, 2015-05-07 03:12:53]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-05-07 03:12:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1131793002/#ps40001
(title: "Annotate the prefobject type.")

[commit-bot: I haz the power, 2015-05-07 03:14:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793002/40001

[commit-bot: I haz the power, 2015-05-07 03:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 03:22:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jeremy Klein, 2015-05-07 03:26:39]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-05-07 03:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1131793002/#ps60001
(title: "css license")

[commit-bot: I haz the power, 2015-05-07 03:27:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793002/60001

[commit-bot: I haz the power, 2015-05-07 03:46:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 03:46:19]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jeremy Klein, 2015-05-07 03:50:38]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-05-07 03:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1131793002/#ps80001
(title: "update settings_resources.grd")

[commit-bot: I haz the power, 2015-05-07 03:51:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131793002/80001

[commit-bot: I haz the power, 2015-05-07 05:19:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-07 05:20:00]

Patchset 5 (id:??) landed as
https://crrev.com/6382609b0412bacd5fc8a719f01bef4927e96287
Cr-Commit-Position: refs/heads/master@{#328713}