src/compiler/arm/code-generator-arm.cc - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: New test, address nits Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index 306c347f8a16cff03d2ffad3cffa470e7dd6f1e1..9c10488261678cb33e0e8dae7f1b8839dfcc6917 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -926,7 +926,7 @@ void CodeGenerator::AssemblePrologue() {

int stack_slots = frame()->GetSpillSlotCount();

if (descriptor->kind() == CallDescriptor::kCallAddress) {

bool saved_pp;

- if (FLAG_enable_ool_constant_pool) {

+ if (FLAG_enable_embedded_constant_pool) {

__ Push(lr, fp, pp);

// Adjust FP to point to saved FP.

__ sub(fp, sp, Operand(StandardFrameConstants::kConstantPoolOffset));