test/cctest/test-compiler.cc - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-compiler.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-compiler.cc

diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc

index ed8b1c6d998c0d1f8aabc172d73ba3f9da1d87ab..c7a107328c374baede768004606e1568133174b2 100644

--- a/test/cctest/test-compiler.cc

+++ b/test/cctest/test-compiler.cc

@@ -533,6 +533,9 @@ static void CheckCodeForUnsafeLiteral(Handle<JSFunction> f) {

int decode_size =

Min(f->code()->instruction_size(),

static_cast<int>(f->code()->back_edge_table_offset()));

+ if (FLAG_enable_embedded_constant_pool) {

+ decode_size = Min(decode_size, f->code()->constant_pool_offset());

+ }

Address end = pc + decode_size;

v8::internal::EmbeddedVector<char, 128> decode_buffer;