src/ppc/deoptimizer-ppc.cc - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/deoptimizer-ppc.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ppc/deoptimizer-ppc.cc

diff --git a/src/ppc/deoptimizer-ppc.cc b/src/ppc/deoptimizer-ppc.cc

index 74c88e37a76796116be8f52c00c839d4388596a9..ccb1c1b596687e7091e455e6122a076e2f164144 100644

--- a/src/ppc/deoptimizer-ppc.cc

+++ b/src/ppc/deoptimizer-ppc.cc

@@ -356,8 +356,8 @@ void FrameDescription::SetCallerFp(unsigned offset, intptr_t value) {

void FrameDescription::SetCallerConstantPool(unsigned offset, intptr_t value) {

- // No out-of-line constant pool support.

- UNREACHABLE();

+ DCHECK(FLAG_enable_embedded_constant_pool);

+ SetFrameSlot(offset, value);

}