src/heap/heap-inl.h - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap-inl.h

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap-inl.h

diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h

index 38deb1f31df4c49b8325dd79a04e4ce813116e72..3d5174cede03aac7454b67e96dee98def6113f4a 100644

--- a/src/heap/heap-inl.h

+++ b/src/heap/heap-inl.h

@@ -149,12 +149,6 @@ AllocationResult Heap::CopyFixedDoubleArray(FixedDoubleArray* src) {

}

-AllocationResult Heap::CopyConstantPoolArray(ConstantPoolArray* src) {

- if (src->length() == 0) return src;

- return CopyConstantPoolArrayWithMap(src, src->map());

AllocationResult Heap::AllocateRaw(int size_in_bytes, AllocationSpace space,

AllocationSpace retry_space) {

DCHECK(AllowHandleAllocation::IsAllowed());