src/heap-snapshot-generator.cc - Issue 1131783003: Embedded constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 1131783003: Embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address remaining comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 34db11ba5d8f197b01924adea218d5e82c163463..7f2b184240e9b120a918a421fe7fde3f9707ebd0 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1500,9 +1500,6 @@ void V8HeapExplorer::ExtractCodeReferences(int entry, Code* code) {

SetInternalReference(code, entry,

"gc_metadata", code->gc_metadata(),

Code::kGCMetadataOffset);

- SetInternalReference(code, entry,

- "constant_pool", code->constant_pool(),

- Code::kConstantPoolOffset);

if (code->kind() == Code::OPTIMIZED_FUNCTION) {

SetWeakReference(code, entry,

"next_code_link", code->next_code_link(),