Chromium Code Reviews| Index: src/arm/lithium-codegen-arm.cc |
| diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc |
| index b9c7328aeedeead9a1f487d827d180fda21d6d73..f33665a657dc7c16fbc0f63e674034478a1b0503 100644 |
| --- a/src/arm/lithium-codegen-arm.cc |
| +++ b/src/arm/lithium-codegen-arm.cc |
| @@ -113,7 +113,7 @@ bool LCodeGen::GeneratePrologue() { |
| // r1: Callee's JS function. |
| // cp: Callee's context. |
| - // pp: Callee's constant pool pointer (if FLAG_enable_ool_constant_pool) |
| + // pp: Callee's constant pool pointer (if enabled) |
| // fp: Caller's frame pointer. |
| // lr: Caller's pc. |
| @@ -383,9 +383,13 @@ bool LCodeGen::GenerateJumpTable() { |
| __ bx(entry_offset); |
| } |
| - // Force constant pool emission at the end of the deopt jump table to make |
| - // sure that no constant pools are emitted after. |
| - masm()->CheckConstPool(true, false); |
| + if (FLAG_enable_embedded_constant_pool) { |
| + masm()->EmitConstantPool(); |
|
rmcilroy
2015/05/20 14:32:10
Same question as full-codegen
MTBrandyberry
2015/05/20 22:28:22
See earlier response.
|
| + } else { |
| + // Force constant pool emission at the end of the deopt jump table to make |
| + // sure that no constant pools are emitted after. |
| + masm()->CheckConstPool(true, false); |
| + } |
| // The deoptimization jump table is the last part of the instruction |
| // sequence. Mark the generated code as done unless we bailed out. |
| @@ -1016,10 +1020,6 @@ void LCodeGen::RecordSafepoint( |
| safepoint.DefinePointerRegister(ToRegister(pointer), zone()); |
| } |
| } |
| - if (FLAG_enable_ool_constant_pool && (kind & Safepoint::kWithRegisters)) { |
| - // Register pp always contains a pointer to the constant pool. |
| - safepoint.DefinePointerRegister(pp, zone()); |
| - } |
| } |