Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1131773004: content: Port layout_test_helper target to GN build. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Port layout_test_helper target to GN build. This is necessary because it is one of the dependencies of the 'blink_tests' group that should be built. BUG=483171 R=avi@chromium.org,dpranke@chromium.org Committed: https://crrev.com/10ae51f628f7447699baf16db52c5d74f9a96077 Cr-Commit-Position: refs/heads/master@{#329580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
tfarina
5 years, 7 months ago (2015-05-12 14:53:33 UTC) #1
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-12 15:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131773004/1
5 years, 7 months ago (2015-05-12 20:11:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63102)
5 years, 7 months ago (2015-05-12 20:19:30 UTC) #6
tfarina
Dirk, I need your approval for src/BUILD.gn
5 years, 7 months ago (2015-05-12 20:30:23 UTC) #7
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-13 00:41:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131773004/1
5 years, 7 months ago (2015-05-13 03:32:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 03:36:07 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 03:36:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10ae51f628f7447699baf16db52c5d74f9a96077
Cr-Commit-Position: refs/heads/master@{#329580}

Powered by Google App Engine
This is Rietveld 408576698