Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1131763003: Do not restrict the visibility of webkit_unit_tests to only third_party/WebKit. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not restrict the visibility of webkit_unit_tests to only third_party/WebKit. We need to access this unit test target from Chromium, hence we need to make it accessibile outside of Blink. The error is as follow: ERROR at //BUILD.gn:723:3: Dependency not allowed. group("blink_tests") { ^--------------------- The item //:blink_tests can not depend on //third_party/WebKit/Source/web:webkit_unit_tests because it is not in //third_party/WebKit/Source/web:webkit_unit_tests's //visibility list: [ //third_party/WebKit/* ] BUG=483171 TEST=gn gen out-gn/Debug R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/web/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
5 years, 7 months ago (2015-05-06 23:58:22 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-07 01:38:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131763003/1
5 years, 7 months ago (2015-05-07 02:44:08 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 04:37:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195024

Powered by Google App Engine
This is Rietveld 408576698