Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: net/socket/stream_socket.h

Issue 1131763002: Reject renegotiations in SSLClientSocket by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/stream_socket.h
diff --git a/net/socket/stream_socket.h b/net/socket/stream_socket.h
index 30a199e2dc3c9f24e3ec07ac583209b38ef1c9e4..9e9f251313c9fb6580fc1cadf05dcb5e326d2364 100644
--- a/net/socket/stream_socket.h
+++ b/net/socket/stream_socket.h
@@ -95,6 +95,12 @@ class NET_EXPORT_PRIVATE StreamSocket : public Socket {
// SSL was not used by this socket.
virtual bool GetSSLInfo(SSLInfo* ssl_info) = 0;
+ // If an SSL socket, configures whether renegotiations are allowed. By
+ // default, the socket rejects all renegotiations from the peer. This method
+ // may be called after Connect completes to change this behavior. If enabled,
+ // ERR_SSL_CLIENT_AUTH_CERT_NEEDED may be returned from Read.
+ virtual void SetRenegotiationsAllowed(bool allowed) {}
Ryan Sleevi 2015/05/07 01:41:26 = 0
davidben 2015/05/07 19:12:34 Fiiiine. Well, you get to review it. FWIW, EnableT
+
protected:
// The following class is only used to gather statistics about the history of
// a socket. It is only instantiated and used in basic sockets, such as

Powered by Google App Engine
This is Rietveld 408576698