Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: net/http/http_stream_factory_impl_job.cc

Issue 1131763002: Reject renegotiations in SSLClientSocket by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.h » ('j') | net/socket/ssl_client_socket_nss.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job.cc
diff --git a/net/http/http_stream_factory_impl_job.cc b/net/http/http_stream_factory_impl_job.cc
index 38f185a4e9edd69b15517afa531d4c5027430020..a5fd4b7a01c66bf1ce40f158bea58d1bd102801e 100644
--- a/net/http/http_stream_factory_impl_job.cc
+++ b/net/http/http_stream_factory_impl_job.cc
@@ -1118,6 +1118,9 @@ int HttpStreamFactoryImpl::Job::DoCreateStream() {
request_->websocket_handshake_stream_create_helper()
->CreateBasicStream(connection_.Pass(), using_proxy));
} else {
+ // HTTP/1.1 requires renegotiations enabled to support TLS client
+ // authentication coming in during a request.
+ connection_->socket()->SetRenegotiationsAllowed(true);
Ryan Sleevi 2015/05/07 01:41:26 This is also needed for WebSockets, which can and
davidben 2015/05/07 19:12:34 Well, this doesn't break all client certs. Sane de
stream_.reset(new HttpBasicStream(connection_.release(), using_proxy));
}
return OK;
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_nss.h » ('j') | net/socket/ssl_client_socket_nss.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698