net/third_party/nss/patches/norenegotiatelock.patch - Issue 1131763002: Reject renegotiations in SSLClientSocket by default.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/third_party/nss/patches/norenegotiatelock.patch

Issue 1131763002: Reject renegotiations in SSLClientSocket by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 diff --git a/ssl/ssl3con.c b/ssl/ssl3con.c

	2 index 424c1fb..89c98ea 100644

	3 --- a/ssl/ssl3con.c

	4 +++ b/ssl/ssl3con.c

	5 @@ -5532,9 +5532,7 @@ ssl3_HandleHelloRequest(sslSocket *ss)

	6 return SECFailure;

	7 }

	8 if (ss->opt.enableRenegotiation == SSL_RENEGOTIATE_NEVER) {

	9 - ssl_GetXmitBufLock(ss);

	10 - rv = SSL3_SendAlert(ss, alert_warning, no_renegotiation);

	11 - ssl_ReleaseXmitBufLock(ss);

	12 + (void)SSL3_SendAlert(ss, alert_warning, no_renegotiation);

	13 PORT_SetError(SSL_ERROR_RENEGOTIATION_NOT_ALLOWED);

	14 return SECFailure;

	15 }

OLD	NEW

« net/socket/stream_socket.h ('K') | « net/third_party/nss/patches/applypatches.sh ('k') | net/third_party/nss/ssl/ssl3con.c » ('j') | net/third_party/nss/ssl/ssl3con.c » ('J')