Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131753005: Move Android Mojo application files to mojo/application from third_party. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Android Mojo application files to mojo/application from third_party. This is a followup to r329965 Committed: https://crrev.com/7636c5ada7d10f703353ae1ebf659afc7b6890f9 Cr-Commit-Position: refs/heads/master@{#330545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -328 lines) Patch
A mojo/application/public/java/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ApplicationConnection.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ApplicationDelegate.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ApplicationImpl.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ApplicationRunner.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ServiceFactoryBinder.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/java/src/org/chromium/mojo/application/ShellHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/tools/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/java/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationConnection.java View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationDelegate.java View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationImpl.java View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ApplicationRunner.java View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ServiceFactoryBinder.java View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/java/application/src/org/chromium/mojo/application/ShellHelper.java View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
I'm surprised these files aren't used?
5 years, 7 months ago (2015-05-19 14:36:10 UTC) #2
Ken Rockot(use gerrit already)
Huh. lgtm
5 years, 7 months ago (2015-05-19 16:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131753005/1
5 years, 7 months ago (2015-05-19 17:06:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:22:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:24:11 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7636c5ada7d10f703353ae1ebf659afc7b6890f9
Cr-Commit-Position: refs/heads/master@{#330545}

Powered by Google App Engine
This is Rietveld 408576698