Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: media/base/cdm_config.h

Issue 1131753003: Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/cdm_config.h
diff --git a/media/base/cdm_config.h b/media/base/cdm_config.h
new file mode 100644
index 0000000000000000000000000000000000000000..bbbb6fb95c3c3d5bbb60b55ec5e4ca9688dc4555
--- /dev/null
+++ b/media/base/cdm_config.h
@@ -0,0 +1,31 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_CDM_CONFIG_H_
+#define MEDIA_BASE_CDM_CONFIG_H_
+
+#include "media/base/media_export.h"
+
+namespace media {
+
+// The runtime configuration of a CDM as computed by
ddorwin 2015/05/13 06:03:21 ...configuration for new CDM instances... I was g
+// |requestMediaKeySystemAccess|. This is in some sense the Chromium-side
+// counterpart of Blink's WebMediaKeySystemConfiguration.
+struct MEDIA_EXPORT CdmConfig {
+ // Access to a distinctive identifier was requested or required, and the
ddorwin 2015/05/13 06:03:21 This seems like impl details of the caller. Should
sandersd (OOO until July 31) 2015/05/14 00:06:57 Done.
+ // permission was granted.
+ bool allow_distinctive_identifier = false;
+
+ // Access to persistent state was requested or required, and is supported by
+ // the session.
ddorwin 2015/05/13 06:03:21 session?
sandersd (OOO until July 31) 2015/05/14 00:06:57 Done.
+ bool allow_persistent_state = false;
+
+ // The configuration requires the use of secure codecs. This flag is only used
+ // on Android, it should always be false on other platforms.
ddorwin 2015/05/13 06:03:21 We could ifdef it.
sandersd (OOO until July 31) 2015/05/14 00:06:57 We could, but then KeySystemConfigChooser needs to
+ bool use_secure_codecs = false;
ddorwin 2015/05/13 06:03:21 ditto on hardware_/hw_. At least include this in t
sandersd (OOO until July 31) 2015/05/14 00:06:57 Done.
+};
+
+} // namespace media
+
+#endif // MEDIA_BASE_CDM_CONFIG_H_

Powered by Google App Engine
This is Rietveld 408576698