chromecast/browser/media/cast_browser_cdm_factory.cc - Issue 1131753003: Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/media/cast_browser_cdm_factory.cc

Issue 1131753003: Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unittest. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/media/cast_browser_cdm_factory.h ('k') | content/browser/media/cdm/browser_cdm_manager.h » ('j') | content/browser/media/cdm/browser_cdm_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/media/cast_browser_cdm_factory.cc

diff --git a/chromecast/browser/media/cast_browser_cdm_factory.cc b/chromecast/browser/media/cast_browser_cdm_factory.cc

index 10bcfd3247a8d42fe204539d2fd80e166f6c79cc..61d800190902811e862dd14566261b4859702da9 100644

--- a/chromecast/browser/media/cast_browser_cdm_factory.cc

+++ b/chromecast/browser/media/cast_browser_cdm_factory.cc

@@ -17,13 +17,14 @@ namespace media {

scoped_ptr<::media::BrowserCdm> CastBrowserCdmFactory::CreateBrowserCdm(

const std::string& key_system_name,

- bool use_secure_surface,

+ bool use_hw_secure_codecs,

const ::media::SessionMessageCB& session_message_cb,

const ::media::SessionClosedCB& session_closed_cb,

const ::media::LegacySessionErrorCB& legacy_session_error_cb,

const ::media::SessionKeysChangeCB& session_keys_change_cb,

const ::media::SessionExpirationUpdateCB& session_expiration_update_cb) {

- DCHECK(!use_secure_surface) << "Chromecast does not use |use_secure_surface|";

+ DCHECK(!use_hw_secure_codecs)

+ << "Chromecast does not use |use_hw_secure_codecs|";

CastKeySystem key_system(GetKeySystemByName(key_system_name));