Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid.

media/base/cdm_config.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_CDM_CONFIG_H_
+#define MEDIA_BASE_CDM_CONFIG_H_
+
+#include "media/base/media_export.h"
+
+namespace media {
+
+// The runtime configuration of a CDM as computed by

[ddorwin, 2015/05/13 06:03:21]

...configuration for new CDM instances...

I was going to just say "...a CDM instance...", but that wouldn't come from
rMKSA. Instead, rMKSA returns an object for creating CDM instances.

OTOH, if we take the caller impl details out of this (see below), then we can
have a simpler comment.

+// |requestMediaKeySystemAccess|. This is in some sense the Chromium-side
+// counterpart of Blink's WebMediaKeySystemConfiguration.
+struct MEDIA_EXPORT CdmConfig {
+  // Access to a distinctive identifier was requested or required, and the

[ddorwin, 2015/05/13 06:03:21]

This seems like impl details of the caller. Should we just say that it is
allowed?

[sandersd (OOO until July 31), 2015/05/14 00:06:57]

Done.

+  // permission was granted.
+  bool allow_distinctive_identifier = false;
+
+  // Access to persistent state was requested or required, and is supported by
+  // the session.

[ddorwin, 2015/05/13 06:03:21]

session?

[sandersd (OOO until July 31), 2015/05/14 00:06:57]

Done.

+  bool allow_persistent_state = false;
+
+  // The configuration requires the use of secure codecs. This flag is only used
+  // on Android, it should always be false on other platforms.

[ddorwin, 2015/05/13 06:03:21]

We could ifdef it.

[sandersd (OOO until July 31), 2015/05/14 00:06:57]

We could, but then KeySystemConfigChooser needs to be platform-aware. Either way
is fine, but this avoids a pair of ifdefs.

+  bool use_secure_codecs = false;

[ddorwin, 2015/05/13 06:03:21]

ditto on hardware_/hw_. At least include this in the comment.

[sandersd (OOO until July 31), 2015/05/14 00:06:57]

Done.

+};
+
+}  // namespace media
+
+#endif  // MEDIA_BASE_CDM_CONFIG_H_