Plumb |use_secure_codecs| through to BrowserCdmFactoryAndroid.

chromecast/browser/media/cast_browser_cdm_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/media/cast_browser_cdm_factory.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "chromecast/browser/media/cma_message_loop.h"
 #include "chromecast/media/cdm/browser_cdm_cast.h"
 #include "media/base/bind_to_current_loop.h"
 #include "media/base/cdm_key_information.h"
 
 namespace chromecast {
 namespace media {
 
 scoped_ptr<::media::BrowserCdm> CastBrowserCdmFactory::CreateBrowserCdm(
     const std::string& key_system_name,
-    bool use_secure_surface,
+    bool use_secure_codecs,
     const ::media::SessionMessageCB& session_message_cb,
     const ::media::SessionClosedCB& session_closed_cb,
     const ::media::LegacySessionErrorCB& legacy_session_error_cb,
     const ::media::SessionKeysChangeCB& session_keys_change_cb,
     const ::media::SessionExpirationUpdateCB& session_expiration_update_cb) {
-  DCHECK(!use_secure_surface) << "Chromecast does not use |use_secure_surface|";
+  DCHECK(!use_secure_codecs) << "Chromecast does not use |use_secure_codecs|";

[ddorwin, 2015/05/13 06:03:20]

I don't know what it would take to make this happen, but it is probably more
appropriate to pass true and say "Chromecast always uses secure codecs."

[gunsch, 2015/05/13 06:52:37]

That would typically be more accurate, though not in all cases.

For example, we have a BrowserCdm-based ClearKey implementation, which is not a
secure codec.

 
   CastKeySystem key_system(GetKeySystemByName(key_system_name));
 
   scoped_ptr<chromecast::media::BrowserCdmCast> browser_cdm;
   if (key_system == chromecast::media::KEY_SYSTEM_CLEAR_KEY) {
     // TODO(gunsch): handle ClearKey decryption. See crbug.com/441957
   } else {
     browser_cdm = CreatePlatformBrowserCdm(key_system);
   }
 
@@ skipping 11 matching lines @@
         new BrowserCdmCastUi(browser_cdm.Pass(),
                              CmaMessageLoop::GetMessageLoopProxy()));
   }
 
   LOG(INFO) << "No matching key system found.";
   return scoped_ptr< ::media::BrowserCdm>();
 }
 
 }  // namespace media
 }  // namespace chromecast