[Android] Implement scrollTo in terms of scrollBy

[Android] Implement scrollTo in terms of scrollBy

Currently, ContentViewCore.scrollBy injects a GestureScrollUpdate event.
However, without a preceding GestureScrollBegin and trailing
GestureScrollEnd, this can lead to inconsistencies in the input pipeline
state. Fix scrollBy to send the proper gesture event sequence,
also changing scrollTo to be implemented in terms of scrollBy.

BUG=454355
Committed: https://crrev.com/d717dd028765c19c80df4d50a3ce23bc0fcec293
Cr-Commit-Position: refs/heads/master@{#330475}

[jdduke (slow), 2015-05-18 21:31:34]

Patchset #3 (id:40001) has been deleted

[jdduke (slow), 2015-05-18 21:31:52]

jdduke@chromium.org changed reviewers:
+ hush@chromium.org

[jdduke (slow), 2015-05-18 21:31:53]

hush@: PTAL, thanks.

https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1793:
public void scrollBy(float dxPix, float dyPix) {
We have to convert to float at some point anyway, don't care if we do that here
or with an internal helper |scrollByImpl| method.

[hush (inactive), 2015-05-19 00:33:23]

https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1793:
public void scrollBy(float dxPix, float dyPix) {
Hi Jared,
Just making sure I understand it.
Neither scrollBy nor scrollTo is used by Android webview. They are only
overriding the API defined in ContentView and only used by tests at this moment.
So this change won't affect webview.

https://code.google.com/p/chromium/codesearch#search/&q=%5CbscrollBy%5Cb%20f:...

Is there anything that I'm missing? How is it hooking up with the gamepad
controller?

[jdduke (slow), 2015-05-19 00:42:15]

On 2015/05/19 00:33:23, hush wrote:
>
https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
> (right):
> 
>
https://codereview.chromium.org/1131723006/diff/60001/content/public/android/...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1793:
> public void scrollBy(float dxPix, float dyPix) {
> Hi Jared,
> Just making sure I understand it.
> Neither scrollBy nor scrollTo is used by Android webview. They are only
> overriding the API defined in ContentView and only used by tests at this
moment.
> So this change won't affect webview.
> 

I see, I guess I assumed it was used for WebView but never bothered to check... 

>
https://code.google.com/p/chromium/codesearch#search/&q=%5CbscrollBy%5Cb%20f:...
> 
> Is there anything that I'm missing? How is it hooking up with the gamepad
> controller?

We plan to implement gamepad smooth scrolling via CVC.scrollBy:
https://codereview.chromium.org/1089663002/.

[hush (inactive), 2015-05-19 00:55:09]

Okay.
lgtm
Thanks!

[jdduke (slow), 2015-05-19 03:40:43]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2015-05-19 03:41:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723006/60001

[commit-bot: I haz the power, 2015-05-19 03:46:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-05-19 03:48:04]

Patchset 3 (id:??) landed as
https://crrev.com/d717dd028765c19c80df4d50a3ce23bc0fcec293
Cr-Commit-Position: refs/heads/master@{#330475}