Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Side by Side Diff: Source/devtools/front_end/resources/ServiceWorkerCacheViews.js

Issue 1131723005: Fixed Cache Storage inspector blank cells, updated tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {!WebInspector.ServiceWorkerCacheModel} model 8 * @param {!WebInspector.ServiceWorkerCacheModel} model
9 * @param {!WebInspector.ServiceWorkerCacheModel.Cache} cache 9 * @param {!WebInspector.ServiceWorkerCacheModel.Cache} cache
10 */ 10 */
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 }, 160 },
161 161
162 __proto__: WebInspector.VBox.prototype 162 __proto__: WebInspector.VBox.prototype
163 } 163 }
164 164
165 /** 165 /**
166 * @constructor 166 * @constructor
167 * @extends {WebInspector.DataGridNode} 167 * @extends {WebInspector.DataGridNode}
168 * @param {!Object.<string, *>} data 168 * @param {!Object.<string, *>} data
169 */ 169 */
170 WebInspector.SWCacheDataGridNode = function(data) 170 WebInspector.SWCacheDataGridNode = function(data)
pfeldman 2015/05/12 05:28:53 There are no overrides. Drop the class altogether?
dmurph 2015/05/12 05:33:50 SGTM
171 { 171 {
172 WebInspector.DataGridNode.call(this, data, false); 172 WebInspector.DataGridNode.call(this, data, false);
173 this.selectable = true; 173 this.selectable = true;
174 } 174 }
175 175
176 WebInspector.SWCacheDataGridNode.prototype = { 176 WebInspector.SWCacheDataGridNode.prototype = {
177 /**
178 * @override
179 * @return {!Element}
180 */
181 createCell: function(columnIdentifier)
182 {
183 var cell = WebInspector.DataGridNode.prototype.createCell.call(this, col umnIdentifier);
184 var value = this.data[columnIdentifier];
185
186 switch (columnIdentifier) {
187 case "request":
188 case "response":
189 cell.removeChildren();
190 var objectElement = WebInspector.ObjectPropertiesSection.defaultObje ctPresentation(value, true);
191 cell.appendChild(objectElement);
192 break;
193 default:
194 }
195
196 return cell;
197 },
198
199 __proto__: WebInspector.DataGridNode.prototype 177 __proto__: WebInspector.DataGridNode.prototype
200 } 178 }
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698