Add ContextProvider::InvalidateGrContext to reset GL state in GrContext

Add ContextProvider::InvalidateGrContext to reset GL state in GrContext

If rendering code that is shared with GrContext changes any GL state,
then skia caches need to be notified.  This adds InvalidateGrContext()
method that will call private pure virtual method.  InvalidateGrContext
default argument will clear all state in GrContext.

Updated classes that derive from ContextProvider.

R=piman@chromium.org
BUG=

Committed: https://crrev.com/c16f8dcdc00218681934a1425f53c9badefbe01a
Cr-Commit-Position: refs/heads/master@{#329255}

[danakj, 2015-05-06 22:02:06]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-05-06 22:02:06]

ContextProvider::GrContext() -> GrContext::resetContext() ?

[piman, 2015-05-06 22:03:40]

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider.cc
File cc/output/context_provider.cc (right):

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.cc:15: DoInvalidateGrContext(state);
Why this?
Instead you can have each derived class implement InvalidateGrContext

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider.h
File cc/output/context_provider.h (right):

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.h:46: // invalidate the cached OGL state in GrContext
nit: "Invalidates" (uppercase, descriptive rather than imperative), and end with
a period.

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.h:47: void InvalidateGrContext(uint32_t state =
kAll_GrBackendState);
nit: no default arguments, per style guide

[piman, 2015-05-06 22:04:54]

On Wed, May 6, 2015 at 3:02 PM, <danakj@chromium.org> wrote:

> ContextProvider::GrContext() -> GrContext::resetContext() ?
>

We want to avoid implicitly creating the GrContext if it hasn't been
created yet.


> https://codereview.chromium.org/1131723002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[CodeByThePound, 2015-05-06 22:27:55]

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider.cc
File cc/output/context_provider.cc (right):

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.cc:15: DoInvalidateGrContext(state);
On 2015/05/06 22:03:40, piman (Very slow to review) wrote:
> Why this?
> Instead you can have each derived class implement InvalidateGrContext

This is a pattern that allows the default argument to InvalidateGrContext and
not have to propagate it through the derived classes.  If default arguments are
not allowed then this mechanism can be removed.

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider.h
File cc/output/context_provider.h (right):

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.h:46: // invalidate the cached OGL state in GrContext
On 2015/05/06 22:03:40, piman (Very slow to review) wrote:
> nit: "Invalidates" (uppercase, descriptive rather than imperative), and end
with
> a period.

Acknowledged.

https://codereview.chromium.org/1131723002/diff/1/cc/output/context_provider....
cc/output/context_provider.h:47: void InvalidateGrContext(uint32_t state =
kAll_GrBackendState);
On 2015/05/06 22:03:40, piman (Very slow to review) wrote:
> nit: no default arguments, per style guide

Acknowledged.

[piman, 2015-05-07 01:07:08]

LGTM+nit

https://codereview.chromium.org/1131723002/diff/20001/cc/output/context_provi...
File cc/output/context_provider.h (right):

https://codereview.chromium.org/1131723002/diff/20001/cc/output/context_provi...
cc/output/context_provider.h:12: #include
"third_party/skia/include/gpu/GrContext.h"
nit: you shouldn't need this

[CodeByThePound, 2015-05-07 16:02:59]

Added/removed headers.
Added more info to InvalidateGrContext().

[CodeByThePound, 2015-05-07 19:20:54]

The CQ bit was checked by codebythepound@gmail.com

[CodeByThePound, 2015-05-07 19:20:55]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps40001
(title: "Fixed Headers")

[commit-bot: I haz the power, 2015-05-07 19:21:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/40001

[commit-bot: I haz the power, 2015-05-07 19:27:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 19:27:39]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[CodeByThePound, 2015-05-08 01:14:44]

The CQ bit was checked by codebythepound@gmail.com

[CodeByThePound, 2015-05-08 01:14:44]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps80001
(title: "fixed minor formatting issue")

[commit-bot: I haz the power, 2015-05-08 01:15:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/80001

[commit-bot: I haz the power, 2015-05-08 01:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-08 01:29:44]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[CodeByThePound, 2015-05-08 19:18:30]

The CQ bit was checked by codebythepound@gmail.com to run a CQ dry run

[CodeByThePound, 2015-05-08 19:18:31]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps100001
(title: "Updated all tests that use ContextProvider.")

[commit-bot: I haz the power, 2015-05-08 19:19:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/100001

[commit-bot: I haz the power, 2015-05-08 19:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-08 19:52:34]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[CodeByThePound, 2015-05-08 20:28:44]

The CQ bit was checked by codebythepound@gmail.com to run a CQ dry run

[CodeByThePound, 2015-05-08 20:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps120001
(title: "Android updates.")

[commit-bot: I haz the power, 2015-05-08 20:31:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/120001

[commit-bot: I haz the power, 2015-05-08 22:33:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-08 22:33:20]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[CodeByThePound, 2015-05-08 23:32:00]

The CQ bit was checked by codebythepound@gmail.com to run a CQ dry run

[CodeByThePound, 2015-05-08 23:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps140001
(title: "More android fixes.")

[commit-bot: I haz the power, 2015-05-08 23:39:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/140001

[commit-bot: I haz the power, 2015-05-09 01:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 01:22:56]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[CodeByThePound, 2015-05-09 02:46:19]

Can someone explain how to build android locally?

[CodeByThePound, 2015-05-09 19:26:34]

The CQ bit was checked by codebythepound@gmail.com to run a CQ dry run

[CodeByThePound, 2015-05-09 19:26:35]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps160001
(title: "More android and mojo fixes.")

[commit-bot: I haz the power, 2015-05-09 19:27:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/160001

[commit-bot: I haz the power, 2015-05-09 23:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 23:31:22]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[CodeByThePound, 2015-05-10 07:04:38]

The CQ bit was checked by codebythepound@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-10 07:06:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/160001

[commit-bot: I haz the power, 2015-05-10 16:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-10 16:40:57]

Dry run: This issue passed the CQ dry run.

[CodeByThePound, 2015-05-11 00:50:55]

codebythepound@gmail.com changed reviewers:
+ ben@chromium.org, boliu@chromium.org, codebythepound@gmail.com
- CodeByThePound@gmail.com

[CodeByThePound, 2015-05-11 00:52:07]

Added reviewers for mojo and android. Please review.  Thanks

[boliu, 2015-05-11 15:36:53]

android_webview lgtm

[CodeByThePound, 2015-05-11 16:19:42]

codebythepound@gmail.com changed reviewers:
+ blundell@chromium.org

[piman, 2015-05-11 19:35:31]

piman@chromium.org changed reviewers:
+ jamesr@chromium.org
- ben@chromium.org

[jamesr, 2015-05-11 19:38:34]

I'm not an OWNER of any parts of this patch other than cc, AFAIK, but the mojo/
bits do look good

[piman, 2015-05-11 19:47:24]

piman@chromium.org changed reviewers:
+ sky@chromium.org

[piman, 2015-05-11 19:47:26]

+sky for mojo/cc

[sky, 2015-05-11 20:19:05]

LGTM

[CodeByThePound, 2015-05-11 20:19:39]

The CQ bit was checked by codebythepound@gmail.com

[commit-bot: I haz the power, 2015-05-11 20:20:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/160001

[commit-bot: I haz the power, 2015-05-11 20:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 20:51:18]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[CodeByThePound, 2015-05-11 21:24:10]

The CQ bit was checked by codebythepound@gmail.com

[CodeByThePound, 2015-05-11 21:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
boliu@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1131723002/#ps180001
(title: "fix int/uint typo")

[commit-bot: I haz the power, 2015-05-11 21:27:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131723002/180001

[commit-bot: I haz the power, 2015-05-11 22:29:20]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-05-11 22:30:24]

Patchset 10 (id:??) landed as
https://crrev.com/c16f8dcdc00218681934a1425f53c9badefbe01a
Cr-Commit-Position: refs/heads/master@{#329255}

[danakj, 2015-10-13 22:55:54]

https://codereview.chromium.org/1131723002/diff/180001/cc/test/test_context_p...
File cc/test/test_context_provider.cc (right):

https://codereview.chromium.org/1131723002/diff/180001/cc/test/test_context_p...
cc/test/test_context_provider.cc:120: gr_context_.get()->resetContext(state);
foo_.get()->bar() should be written foo_->bar()