Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js

Issue 1131713006: Update paper-drawer-panel to 0.8.4 to pick up some fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js
diff --git a/third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js b/third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js
index 2e1071f9c347a48f1da2eda602a7c01b82e8776a..a514a88e133c43b18bbb6858a70607f35a4c9552 100644
--- a/third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js
+++ b/third_party/polymer/v0_8/components-chromium/paper-drawer-panel/paper-drawer-panel-extracted.js
@@ -136,7 +136,8 @@
narrow: {
reflectToAttribute: true,
type: Boolean,
- value: false
+ value: false,
+ notify: true
},
// Whether the drawer is peeking out from the edge.
@@ -213,8 +214,8 @@
},
listeners: {
- click: 'onClick',
- track: 'onTrack'
+ tap: '_onTap',
+ track: '_onTrack'
// TODO: Implement tap handlers when taps are supported.
//
@@ -257,7 +258,7 @@
return !narrow || disableEdgeSwipe;
},
- onTrack: function(event) {
+ _onTrack: function(event) {
switch (event.detail.state) {
case 'end':
this.trackEnd(event);
@@ -349,22 +350,21 @@
}
},
- // TODO: Implement tap handlers when taps are supported.
- //
- // downHandler: function(e) {
- // if (!this.dragging && this.isMainSelected() && this.isEdgeTouch(e)) {
- // this.startEdgePeek();
- // }
- // },
- //
- // upHandler: function(e) {
- // this.stopEdgePeek();
- // },
-
- onClick: function(e) {
- var isTargetToggleElement = e.target &&
+ _downHandler: function(e) {
+ if (!this.dragging && this._isMainSelected() && this._isEdgeTouch(e)) {
+ this._startEdgePeek();
+ }
+ },
+
+ _upHandler: function(e) {
+ this._stopEdgePeek();
+ },
+
+ _onTap: function(e) {
+ var targetElement = Polymer.dom(e).localTarget;
+ var isTargetToggleElement = targetElement &&
this.drawerToggleAttribute &&
- e.target.hasAttribute(this.drawerToggleAttribute);
+ targetElement.hasAttribute(this.drawerToggleAttribute);
if (isTargetToggleElement) {
this.togglePanel();
@@ -461,11 +461,6 @@
} else {
s.webkitTransform = this.transformForTranslateX(translateX);
}
- },
-
- onSelect: function(e) {
- e.preventDefault();
- this.selected = e.detail.selected;
}
});

Powered by Google App Engine
This is Rietveld 408576698