Issue 1131713004: Revert of Remove Scope::scope_uses_this_ flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131713004: Revert of Remove Scope::scope_uses_this_ flag (Closed)

Created:
5 years, 7 months ago by Michael Achenbach

Modified:
5 years, 7 months ago

Reviewers:
wingo, arv (Not doing code reviews)

CC:
v8-dev, rossberg, Dmitry Lomov (no reviews)

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Remove Scope::scope_uses_this_ flag (patchset #1 id:1 of https://codereview.chromium.org/1129823002/) Reason for revert: The reason for reverting is: [Sheriff] Need to fix compilation after this revert: https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411 Original issue's description: > Remove Scope::scope_uses_this_ flag > > Use of the "this" variable is now tracked using scopes, like any other variable. > > R=arv@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/afba55965118d9ba57e53c729f52be2340e626e0 > Cr-Commit-Position: refs/heads/master@{#28268} TBR=arv@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/36f5f4007445c1c8092f2c755ab62bfc034a288c Cr-Commit-Position: refs/heads/master@{#28285}

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -12 lines)			Patch
M	src/compiler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/preparser.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/scopes.h	View	4 chunks	+10 lines, -0 lines	0 comments	Download
M	src/scopes.cc	View	5 chunks	+8 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	5 chunks	+11 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of Remove Scope::scope_uses_this_ flag

5 years, 7 months ago (2015-05-07 07:46:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131713004/1

5 years, 7 months ago (2015-05-07 07:46:56 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-07 07:47:21 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/36f5f4007445c1c8092f2c755ab62bfc034a288c
Cr-Commit-Position: refs/heads/master@{#28285}