Issue 1131683003: tools/gn: Fix the includes of target_generator.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131683003: tools/gn: Fix the includes of target_generator.h header. (Closed)

Created:
5 years, 7 months ago by tfarina

Modified:
5 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

tools/gn: Fix the includes of target_generator.h header. Plus a few other small clang-format fixes. BUG=None R=scottmg@chromium.org Committed: https://crrev.com/e451f6d6ae7df616c1dd5b9965665a5050730a9e Cr-Commit-Position: refs/heads/master@{#330003}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	tools/gn/action_target_generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/binary_target_generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/group_target_generator.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/gn/group_target_generator.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/target_generator.h	View	2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131683003/1

5 years, 7 months ago (2015-05-15 01:00:01 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 01:06:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e451f6d6ae7df616c1dd5b9965665a5050730a9e
Cr-Commit-Position: refs/heads/master@{#330003}