Teach SkyView code path to print hello, world

sky/engine/core/script/dart_controller.cc

Index: sky/engine/core/script/dart_controller.cc
diff --git a/sky/engine/core/script/dart_controller.cc b/sky/engine/core/script/dart_controller.cc
index b0b1639438d308ad14b950e83a1418d6fab395e8..f927ebb6ed355d120a412ba1193f99f2f3bc90cf 100644
--- a/sky/engine/core/script/dart_controller.cc
+++ b/sky/engine/core/script/dart_controller.cc
@@ -111,6 +111,9 @@ void DartController::DidLoadMainLibrary(KURL url) {
   DCHECK(Dart_CurrentIsolate() == dart_state()->isolate());
   DartApiScope dart_api_scope;
 
+  if (LogIfError(Dart_FinalizeLoading(true)))
+    return;
+
   Dart_Handle library = Dart_LookupLibrary(
       StringToDart(dart_state(), url.string()));
   CHECK(!LogIfError(library));
@@ -308,13 +311,13 @@ static void MessageNotifyCallback(Dart_Isolate dest_isolate) {
       base::Bind(&CallHandleMessage, DartState::From(dest_isolate)->GetWeakPtr()));
 }
 
-void DartController::CreateIsolateFor(Document* document) {
-  DCHECK(document);
+void DartController::CreateIsolateFor(PassOwnPtr<DOMDartState> state,
+                                      const KURL& url) {
   CHECK(kDartIsolateSnapshotBuffer);
   char* error = nullptr;
-  dom_dart_state_ = adoptPtr(new DOMDartState(document));
+  dom_dart_state_ = state;
   Dart_Isolate isolate = Dart_CreateIsolate(
-      document->url().string().utf8().data(), "main", kDartIsolateSnapshotBuffer,
+      url.string().utf8().data(), "main", kDartIsolateSnapshotBuffer,

[eseidel, 2015/05/19 18:18:36]

We really need a .tempUTF8() helper or some such for these.

       static_cast<DartState*>(dom_dart_state_.get()), &error);
   Dart_SetMessageNotifyCallback(MessageNotifyCallback);
   CHECK(isolate) << error;
@@ -336,9 +339,9 @@ void DartController::CreateIsolateFor(Document* document) {
 
     builtin_sky_ = adoptPtr(new BuiltinSky(dart_state()));
     dart_state()->class_library().set_provider(builtin_sky_.get());
-    builtin_sky_->InstallWindow(dart_state());
 
-    document->frame()->loaderClient()->didCreateIsolate(isolate);
+    if (dart_state()->document())
+      builtin_sky_->InstallWindow(dart_state());
 
     EnsureHandleWatcherStarted();
   }