Issue 1131673011: Teach SkyView code path to print hello, world

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1131673011: Teach SkyView code path to print hello, world (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach SkyView code path to print hello, world This CL makes the SkyView codepath smart enough to print "hello, world" to the console. The code path is off by default but can be enabled by changing one line of code. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/42628e974eeccb563a8e8b9692409adc7360148a

Patch Set 1 #

Total comments: 1

Patch Set 2 : again #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -17 lines)			Patch
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	sky/engine/core/script/dom_dart_state.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
A +	sky/examples/raw/hello_world.dart	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

You make the trybots sad, but the changes lgtm. https://codereview.chromium.org/1131673011/diff/1/sky/engine/core/script/dart_controller.cc File sky/engine/core/script/dart_controller.cc (right): https://codereview.chromium.org/1131673011/diff/1/sky/engine/core/script/dart_controller.cc#newcode320 sky/engine/core/script/dart_controller.cc:320: ...

5 years, 7 months ago (2015-05-19 18:18:37 UTC) #2

abarth-chromium

5 years, 7 months ago (2015-05-19 20:51:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
42628e974eeccb563a8e8b9692409adc7360148a (presubmit successful).

Expand Messages | Collapse Messages