Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1131673009: Revert of Pass Surface ID namespace to renderer compositors. (Closed)

Created:
5 years, 7 months ago by jsbell
Modified:
5 years, 7 months ago
Reviewers:
kenrb, jbauman, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass Surface ID namespace to renderer compositors. (patchset #4 id:60001 of https://codereview.chromium.org/1129883003/) Reason for revert: Speculative revert to address widespread blink layout test failures on mac following a chromium revision in range 329707-329709. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20%28retina%29/builds/655 No stacks but sample output: STDERR: Assertion failed: (impl_.get() != nullptr), function operator->, file ../../base/memory/scoped_ptr.h, line 386. We'll try reproducing locally and watch the bots. We can reland if this does not green up the webkit waterfall. Original issue's description: > Pass Surface ID namespace to renderer compositors. > > In order to enable renderer processes to create SurfaceSequences, they > have to receive Surface ID namespaces from the browser process so that > they can avoid collisions. > > BUG=478802 > > Committed: https://crrev.com/c7a5afd66499fc8442e1b3146f55b227638934d8 > Cr-Commit-Position: refs/heads/master@{#329708} TBR=jbauman@chromium.org,nasko@chromium.org,kenrb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478802 Committed: https://crrev.com/c3ab203e6cd01a5bc2a125d1667e80a5a7f60c99 Cr-Commit-Position: refs/heads/master@{#329736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -95 lines) Patch
M content/browser/compositor/delegated_frame_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jsbell
Created Revert of Pass Surface ID namespace to renderer compositors.
5 years, 7 months ago (2015-05-13 22:23:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131673009/1
5 years, 7 months ago (2015-05-13 22:25:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 22:26:57 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:27:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3ab203e6cd01a5bc2a125d1667e80a5a7f60c99
Cr-Commit-Position: refs/heads/master@{#329736}

Powered by Google App Engine
This is Rietveld 408576698