Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/protobuf/README.chromium

Issue 11316370: [sync] Componentize sync: Part 4: Fix includes in third_party/protobuf (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add missing exports to content/browser/speech/proto/speech_proto.gyp Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/README.chromium
diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium
index 25997374c514781cecb6f52c0cf29a076746bb79..cf20a68f1bdae35b23c68c904d7d18dd3e74c0f8 100644
--- a/third_party/protobuf/README.chromium
+++ b/third_party/protobuf/README.chromium
@@ -14,11 +14,16 @@ descriptor2_pb.py
protobuf_lite_java_descriptor_proto.py
protobuf_lite_java_parse_pom.py
-A protobuf.gyp file has been added for building with Chromium.
+A protobuf.gyp file has been added for building with Chromium. It supports the
+building of libproto_lite as a shared library for Windows component builds.
This code has been patched to support unknown field retention in protobuf-lite.
See r62331 for the patch.
+This code has been patched to ensure that files in the target protobuf_lite
+do not include headers from protobuf_full. See rXXXXXX for the patch.
+TODO(rsimha): Update rXXXXXX above once the patch is committed.
+
Revisions r427 and r430 were cherry-picked from upstream.
Cherry-pick patch from http://code.google.com/p/protobuf/issues/detail?id=425.

Powered by Google App Engine
This is Rietveld 408576698