Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/protobuf/README.chromium

Issue 11316370: [sync] Componentize sync: Part 4: Fix includes in third_party/protobuf (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/README.chromium
diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium
index 25997374c514781cecb6f52c0cf29a076746bb79..3af2edca096ad96b26a9be6aa90e05e24173648d 100644
--- a/third_party/protobuf/README.chromium
+++ b/third_party/protobuf/README.chromium
@@ -14,7 +14,8 @@ descriptor2_pb.py
protobuf_lite_java_descriptor_proto.py
protobuf_lite_java_parse_pom.py
-A protobuf.gyp file has been added for building with Chromium.
+A protobuf.gyp file has been added for building with Chromium. It supports the
+building of libproto_lite as a shared library for Windows component builds.
akalin 2012/12/13 02:04:50 component build is also on Linux/Mac at this point
Raghu Simha 2012/12/13 20:07:49 Right, but the changes in protobuf.gyp are only wi
This code has been patched to support unknown field retention in protobuf-lite.
agl 2012/12/13 15:41:41 Can you grab the changes as a .patch file and chec
Raghu Simha 2012/12/13 20:07:49 I think it might be cleaner in the long run to ref
See r62331 for the patch.

Powered by Google App Engine
This is Rietveld 408576698