third_party/protobuf/README.chromium - Issue 11316370: [sync] Componentize sync: Part 4: Fix includes in third_party/protobuf

Side by Side Diff: third_party/protobuf/README.chromium

Issue 11316370: [sync] Componentize sync: Part 4: Fix includes in third_party/protobuf (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Name: Protocol Buffers	1 Name: Protocol Buffers

2 Short Name: protobuf	2 Short Name: protobuf

3 URL: http://protobuf.googlecode.com/svn/trunk	3 URL: http://protobuf.googlecode.com/svn/trunk

4 License: BSD	4 License: BSD

5 License File: COPYING.txt	5 License File: COPYING.txt

6 Version: unknown	6 Version: unknown

7 Revision: r423	7 Revision: r423

8 Security Critical: yes	8 Security Critical: yes

9	9

10 Local files (not taken from upstream):	10 Local files (not taken from upstream):

11 README.chromium	11 README.chromium

12 config.h	12 config.h

13 descriptor2_pb.py	13 descriptor2_pb.py

14 protobuf_lite_java_descriptor_proto.py	14 protobuf_lite_java_descriptor_proto.py

15 protobuf_lite_java_parse_pom.py	15 protobuf_lite_java_parse_pom.py

16	16

17 A protobuf.gyp file has been added for building with Chromium.	17 A protobuf.gyp file has been added for building with Chromium. It supports the

	18 building of libproto_lite as a shared library for Windows component builds.
	akalin 2012/12/13 02:04:50 component build is also on Linux/Mac at this point component build is also on Linux/Mac at this point, I think. Raghu Simha 2012/12/13 20:07:49 Right, but the changes in protobuf.gyp are only wi Show quoted text On 2012/12/13 02:04:50, akalin wrote: > component build is also on Linux/Mac at this point, I think. Right, but the changes in protobuf.gyp are only windows specific, as they have to do with VS projects. Mac and Linux component builds work as they are without the change.
18	19

19 This code has been patched to support unknown field retention in protobuf-lite.	20 This code has been patched to support unknown field retention in protobuf-lite.
	agl 2012/12/13 15:41:41 Can you grab the changes as a .patch file and chec Can you grab the changes as a .patch file and check it in + reference it here? Alternatively, you can reference the SVN revision number, although you'll have to commit with "rxxx" and update it once landed. (Or get lucky :) Raghu Simha 2012/12/13 20:07:49 I think it might be cleaner in the long run to ref Show quoted text On 2012/12/13 15:41:41, agl wrote: > Can you grab the changes as a .patch file and check it in + reference it here? > Alternatively, you can reference the SVN revision number, although you'll have > to commit with "rxxx" and update it once landed. (Or get lucky :) I think it might be cleaner in the long run to reference the SVN number as you've done here. I'll update the comment in another CL.
20 See r62331 for the patch.	21 See r62331 for the patch.

21	22

22 Revisions r427 and r430 were cherry-picked from upstream.	23 Revisions r427 and r430 were cherry-picked from upstream.

23	24

24 Cherry-pick patch from http://code.google.com/p/protobuf/issues/detail?id=425.	25 Cherry-pick patch from http://code.google.com/p/protobuf/issues/detail?id=425.

25	26

26 Notes about Java:	27 Notes about Java:

27 We have not forked the Java version of protobuf-lite, so the Java version does	28 We have not forked the Java version of protobuf-lite, so the Java version does

28 not support unknown field retention.	29 not support unknown field retention.

29	30

30 The list of Java files included in the lite profile for Java is parsed from the	31 The list of Java files included in the lite profile for Java is parsed from the

31 maven java/pom.xml by the script protobuf_lite_java_parse_pom.py. See	32 maven java/pom.xml by the script protobuf_lite_java_parse_pom.py. See

32 'javac_includes' variable in protobuf_lite_javalib GYP target.	33 'javac_includes' variable in protobuf_lite_javalib GYP target.

33	34

OLD	NEW

« no previous file with comments | « remoting/protocol/connection_to_client.cc ('k') | third_party/protobuf/protobuf.gyp » ('j') | third_party/protobuf/protobuf.gyp » ('J')