Issue 11316337: aura-x11: Avoid calling XISelectEvents on the root-window multiple times.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316337: aura-x11: Avoid calling XISelectEvents on the root-window multiple times. (Closed)

Created:
8 years ago by sadrul

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura-x11: Avoid calling XISelectEvents on the root-window multiple times. Calling XISelectEvents multiple on the root-window causes an X error (BadImplementation) This happens when logging in in incognito mode. So first check if the root-window is already listening for XI2 events. BUG=153976

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	ui/aura/root_window_host_linux.cc	View		2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

8 years ago (2012-12-05 00:37:37 UTC) #3

Abandoning this in favour of https://codereview.chromium.org/11437005/

Expand Messages | Collapse Messages