src/api.cc - Issue 11316331: Pass Isolate to Local<T>::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 11316331: Pass Isolate to Local<T>::New() (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Isolate argument first Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 39741f5b42a8708828c55b6b83b287eb485f232b..28e2f9285ef7b404a78063760a920c1cf7add9fd 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -769,6 +769,12 @@ i::Object** HandleScope::CreateHandle(i::Object* value) {

}

+i::Object** HandleScope::CreateHandle(i::Isolate* isolate, i::Object* value) {

+ ASSERT(isolate == i::Isolate::Current());

+ return i::HandleScope::CreateHandle(value, isolate);

i::Object** HandleScope::CreateHandle(i::HeapObject* value) {

ASSERT(value->IsHeapObject());

return reinterpret_cast<i::Object**>(

« no previous file with comments | « include/v8.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »