Pass Isolate to Local<T>::New()

Pass Isolate to Local<T>::New()

Our profiling revealed that Local<T>::New() is one of bottlenecks of DOM bindings.

BUG=
TEST=cctest/test-api/LocalHandle

Committed: http://code.google.com/p/v8/source/detail?r=13138

[haraken, 2012-12-04 12:52:07]

Local::New() is a bottleneck when we convert a WebKit string to a V8 string,
which is a super hot path.

Could you take a look?

[Michael Starzinger (Google), 2012-12-04 17:31:38]

https://chromiumcodereview.appspot.com/11316331/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/11316331/diff/1/include/v8.h#newcode308
include/v8.h:308: inline static Local<T> New(Handle<T> that, Isolate* isolate);
I actually think the isolate parameter should go first. We already have one
instance (i.e. Integer::New) with the opposite order, but I still think having
the isolate first would be a better convention.

When I was talking to Sven a few weeks ago, we agreed that in a perfect world
all functions that need the isolate should take it as an explicit parameter and
the non-isolate versions should slowly be deprecated.

[haraken, 2012-12-05 00:16:01]

Thanks for reviewing!

> When I was talking to Sven a few weeks ago, we agreed that in a perfect world
> all functions that need the isolate should take it as an explicit parameter
and
> the non-isolate versions should slowly be deprecated.

I'm happy to do the work from V8 APIs that are critical for V8 binding
performance.

https://chromiumcodereview.appspot.com/11316331/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/11316331/diff/1/include/v8.h#newcode308
include/v8.h:308: inline static Local<T> New(Handle<T> that, Isolate* isolate);
On 2012/12/04 17:31:38, Michael Starzinger (Google) wrote:
> I actually think the isolate parameter should go first. We already have one
> instance (i.e. Integer::New) with the opposite order, but I still think having
> the isolate first would be a better convention.
> 
> When I was talking to Sven a few weeks ago, we agreed that in a perfect world
> all functions that need the isolate should take it as an explicit parameter
and
> the non-isolate versions should slowly be deprecated.

Done.

[Michael Starzinger, 2012-12-05 09:07:21]

LGTM. Rebasing. Landing.