Issue 11316329: TabCapture favicon glow for views.

Issue 11316329: TabCapture favicon glow for views. (Closed)

Created:
8 years ago by justinlin

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TabCapture favicon glow for views. BUG=158086 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171118

Patch Set 2 : enum #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -16 lines)			Patch
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	1	2 chunks	+71 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_renderer_data.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_renderer_data.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11316329/diff/1/chrome/browser/ui/views/tabs/tab_renderer_data.h File chrome/browser/ui/views/tabs/tab_renderer_data.h (right): https://codereview.chromium.org/11316329/diff/1/chrome/browser/ui/views/tabs/tab_renderer_data.h#newcode27 chrome/browser/ui/views/tabs/tab_renderer_data.h:27: NONE, Prefix these with CAPTURE_STATE, eg CAPTURE_STATE_NONE, CAPTURE_STATE_RECORDING ...

8 years ago (2012-12-04 16:59:27 UTC) #2

justinlin

https://codereview.chromium.org/11316329/diff/1/chrome/browser/ui/views/tabs/tab_renderer_data.h File chrome/browser/ui/views/tabs/tab_renderer_data.h (right): https://codereview.chromium.org/11316329/diff/1/chrome/browser/ui/views/tabs/tab_renderer_data.h#newcode27 chrome/browser/ui/views/tabs/tab_renderer_data.h:27: NONE, On 2012/12/04 16:59:28, sky wrote: > Prefix these ...

8 years ago (2012-12-04 20:33:08 UTC) #3

commit-bot: I haz the power

8 years ago (2012-12-04 20:36:26 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justinlin@chromium.org/11316329/4001

Expand Messages | Collapse Messages