Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/prerender/prerender_handle.cc

Issue 11316311: Make PrerenderHandle an observer of PrerenderContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another remediation Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_handle.h" 5 #include "chrome/browser/prerender/prerender_handle.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "chrome/browser/prerender/prerender_contents.h" 9 #include "chrome/browser/prerender/prerender_contents.h"
mmenke 2012/12/13 21:39:43 #include "base/logging.h" for DCHECK.
gavinp 2012/12/13 22:01:56 Done.
10 10
11 namespace prerender { 11 namespace prerender {
12 12
13 PrerenderHandle::Observer::Observer() {
14 }
15
16 PrerenderHandle::Observer::~Observer() {
17 }
18
13 PrerenderHandle::~PrerenderHandle() { 19 PrerenderHandle::~PrerenderHandle() {
14 DCHECK(!IsValid()); 20 if (prerender_data_) {
15 // This shouldn't occur, but we also shouldn't leak if it does. 21 prerender_data_->contents()->RemoveObserver(this);
16 if (IsValid()) 22 }
17 OnCancel(); 23 }
24
25 void PrerenderHandle::SetObserver(Observer* observer) {
26 DCHECK_NE(static_cast<Observer*>(NULL), observer);
27 observer_ = observer;
18 } 28 }
19 29
20 void PrerenderHandle::OnNavigateAway() { 30 void PrerenderHandle::OnNavigateAway() {
21 DCHECK(CalledOnValidThread()); 31 DCHECK(CalledOnValidThread());
22 if (!IsValid()) 32 if (prerender_data_)
23 return; 33 prerender_data_->OnHandleNavigatedAway(this);
24 prerender_data_->OnNavigateAwayByHandle();
25 prerender_data_.reset();
26 } 34 }
27 35
28 void PrerenderHandle::OnCancel() { 36 void PrerenderHandle::OnCancel() {
29 DCHECK(CalledOnValidThread()); 37 DCHECK(CalledOnValidThread());
30 if (!IsValid()) 38 if (prerender_data_)
31 return; 39 prerender_data_->OnHandleCanceled(this);
32 prerender_data_->OnCancelByHandle();
33 prerender_data_.reset();
34 }
35
36 bool PrerenderHandle::IsValid() const {
37 return prerender_data_ != NULL;
38 }
39
40 bool PrerenderHandle::IsPending() const {
41 DCHECK(CalledOnValidThread());
42 return prerender_data_ && !prerender_data_->contents();
43 } 40 }
44 41
45 bool PrerenderHandle::IsPrerendering() const { 42 bool PrerenderHandle::IsPrerendering() const {
46 DCHECK(CalledOnValidThread()); 43 DCHECK(CalledOnValidThread());
47 return prerender_data_ && prerender_data_->contents(); 44 return prerender_data_ != NULL;
48 } 45 }
49 46
50 bool PrerenderHandle::IsFinishedLoading() const { 47 bool PrerenderHandle::IsFinishedLoading() const {
51 DCHECK(CalledOnValidThread()); 48 DCHECK(CalledOnValidThread());
52 if (!prerender_data_ || IsPending()) 49 if (!prerender_data_)
53 return false; 50 return false;
54 return prerender_data_->contents()->has_finished_loading(); 51 return prerender_data_->contents()->has_finished_loading();
55 } 52 }
56 53
57 PrerenderHandle::PrerenderHandle( 54 PrerenderHandle::PrerenderHandle(
58 PrerenderManager::PrerenderData* prerender_data) 55 PrerenderManager::PrerenderData* prerender_data)
59 : prerender_data_(prerender_data->AsWeakPtr()), 56 : observer_(NULL),
60 weak_ptr_factory_(this) { 57 weak_ptr_factory_(this) {
61 prerender_data->OnNewHandle(); 58 if (prerender_data) {
59 prerender_data_ = prerender_data->AsWeakPtr();
60 prerender_data->OnHandleCreated(this);
61 }
62 } 62 }
63 63
64 void PrerenderHandle::SwapPrerenderDataWith( 64 void PrerenderHandle::AdoptPrerenderDataFrom(PrerenderHandle* other_handle) {
65 PrerenderHandle* other_prerender_handle) { 65 DCHECK_EQ(static_cast<PrerenderManager::PrerenderData*>(NULL),
66 prerender_data_);
67 if (other_handle->prerender_data_ &&
68 other_handle->prerender_data_->contents()) {
69 other_handle->prerender_data_->contents()->RemoveObserver(other_handle);
70 }
71
72 prerender_data_ = other_handle->prerender_data_;
73 other_handle->prerender_data_.reset();
74
75 if (prerender_data_) {
76 DCHECK_NE(static_cast<PrerenderContents*>(NULL),
77 prerender_data_->contents());
78 prerender_data_->contents()->AddObserver(this);
79 // We are joining a prerender that has already started so we fire off an
80 // extra start event at ourselves.
81 OnPrerenderStart(prerender_data_->contents());
82 }
83 }
84
85 void PrerenderHandle::OnPrerenderStart(PrerenderContents* prerender_contents) {
66 DCHECK(CalledOnValidThread()); 86 DCHECK(CalledOnValidThread());
67 DCHECK(other_prerender_handle); 87 DCHECK(prerender_data_);
68 std::swap(prerender_data_, other_prerender_handle->prerender_data_); 88 DCHECK_EQ(prerender_data_->contents(), prerender_contents);
89 if (observer_)
90 observer_->OnPrerenderStart(this);
91 }
92
93 void PrerenderHandle::OnPrerenderAddAlias(PrerenderContents* prerender_contents,
94 const GURL& alias_url) {
95 DCHECK(CalledOnValidThread());
96 DCHECK(prerender_data_);
97 DCHECK_EQ(prerender_data_->contents(), prerender_contents);
98 if (observer_)
99 observer_->OnPrerenderAddAlias(this, alias_url);
100 }
101
102 void PrerenderHandle::OnPrerenderStop(PrerenderContents* prerender_contents) {
103 DCHECK(CalledOnValidThread());
104 if (observer_)
105 observer_->OnPrerenderStop(this);
106 }
107
108 void PrerenderHandle::OnPrerenderCreatedMatchCompleteReplacement(
109 PrerenderContents* contents, PrerenderContents* replacement) {
110 DCHECK(CalledOnValidThread());
111
112 // This should occur in the middle of the surgery on the PrerenderData, and
113 // so we expect to not have our new contents in our PrerenderData yet. The
114 // switch occurs in
115 // PrerenderManager::PrerenderData::MakeIntoMatchCompleteReplacement, so
116 // this method only needs to switch observing.
117
118 contents->RemoveObserver(this);
119 replacement->AddObserver(this);
69 } 120 }
70 121
71 } // namespace prerender 122 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698