Issue 11316309: Fix the bug that A11y tray is enabled by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316309: Fix the bug that A11y tray is enabled by default (Closed)

Created:
8 years ago by yoshiki

Modified:
8 years ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the bug that A11y tray is enabled by default BUG=none R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170765

Patch Set 2 : fix indent #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/preferences.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm https://codereview.chromium.org/11316309/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): https://codereview.chromium.org/11316309/diff/1/chrome/browser/chromeos/preferences.cc#newcode120 chrome/browser/chromeos/preferences.cc:120: false, nit: indent this line and the next ...

8 years ago (2012-12-03 18:35:54 UTC) #2

yoshiki

8 years ago (2012-12-03 18:36:43 UTC) #3

Thanks!

https://codereview.chromium.org/11316309/diff/1/chrome/browser/chromeos/prefe...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/11316309/diff/1/chrome/browser/chromeos/prefe...
chrome/browser/chromeos/preferences.cc:120: false,
On 2012/12/03 18:35:54, Daniel Erat wrote:
> nit: indent this line and the next by one more space

Done.

Expand Messages | Collapse Messages

Issue 11316309: Fix the bug that A11y tray is enabled by default (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix indent #

Messages