Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 11316307: Revert 170319 - Removed dead code from chrome/browser/extensions/api/declarative (Closed)

Created:
8 years ago by battre
Modified:
8 years ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 170319 - Removed dead code from chrome/browser/extensions/api/declarative Reverting because this code will be used in the future (it is currently behind a #ifdef check). BUG=161992 Review URL: https://chromiumcodereview.appspot.com/11412247 TBR=sergiyb@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/extensions/api/declarative/rules_registry_with_cache.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
battre
8 years ago (2012-12-03 18:12:29 UTC) #1
Sergiy Byelozyorov (Google)
On 2012/12/03 18:12:29, battre wrote: LGTM
8 years ago (2012-12-03 18:38:38 UTC) #2
Sergiy Byelozyorov (Google)
8 years ago (2012-12-03 18:39:25 UTC) #3
Message was sent while issue was closed.
lgtm

LGTM

Powered by Google App Engine
This is Rietveld 408576698