chrome/browser/first_run/first_run.cc - Issue 11316299: Enable web-based sign in flow by default. Can use command line argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run.cc

Issue 11316299: Enable web-based sign in flow by default. Can use command line argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix BiDi tests and indent Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/first_run/first_run.cc

diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc

index f1737c18131025190b51ca0ce8c34f2654e23a1d..0dc12e859905463ca083f53eb3a62147ca4b56e1 100644

--- a/chrome/browser/first_run/first_run.cc

+++ b/chrome/browser/first_run/first_run.cc

@@ -34,6 +34,7 @@

#include "chrome/browser/ui/global_error/global_error_service.h"

#include "chrome/browser/ui/global_error/global_error_service_factory.h"

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

+#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

@@ -532,8 +533,7 @@ void FirstRunBubbleLauncher::Observe(

content::WebContents* contents = chrome::GetActiveWebContents(browser);

// Suppress the first run bubble if a Gaia sign in page is showing.

- if (CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kUseWebBasedSigninFlow) &&

+ if (SyncPromoUI::UseWebBasedSigninFlow() &&

gaia::IsGaiaSignonRealm(contents->GetURL().GetOrigin())) {

return;

}

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »