Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3226)

Unified Diff: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc

Issue 11316299: Enable web-based sign in flow by default. Can use command line argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
diff --git a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
index 214f9cca2d90f466ebfca62f48e74b778030fd7e..b6f9d2bea68aab319b0545fce1210c71acf98734 100644
--- a/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
+++ b/chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/browser/ui/sync/one_click_signin_helper.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
#include "chrome/browser/ui/webui/options/core_options_handler.h"
@@ -71,13 +72,6 @@ bool AllowPromoAtStartupForCurrentBrand() {
return true;
}
-bool UseWebBasedSigninFlow() {
- const bool use_web_based_singin_flow =
- CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kUseWebBasedSigninFlow);
- return use_web_based_singin_flow;
-}
-
// The Web UI data source for the sync promo page.
class SyncPromoUIHTMLSource : public ChromeWebUIDataSource {
public:
@@ -228,7 +222,7 @@ GURL SyncPromoUI::GetSyncPromoURL(const GURL& next_page,
std::string url_string;
- if (UseWebBasedSigninFlow()) {
+ if (OneClickSigninHelper::UseWebBasedSigninFlow()) {
// Build a Gaia-based URL that can be used to sign the user into chrome.
// There are required request parameters:
//

Powered by Google App Engine
This is Rietveld 408576698