Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6442)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 11316299: Enable web-based sign in flow by default. Can use command line argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index 1c2869bd00db1e5ca89dedda9ecc52af2405c2d5..021e4ed0db3384483018642b8119092068b8515a 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/ui/chrome_pages.h"
-#include "base/command_line.h"
#include "base/logging.h"
#include "base/string_number_conversions.h"
#include "base/stringprintf.h"
@@ -16,10 +15,10 @@
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/singleton_tabs.h"
+#include "chrome/browser/ui/sync/one_click_signin_helper.h"
#include "chrome/browser/ui/webui/options/content_settings_handler.h"
#include "chrome/browser/ui/webui/signin/login_ui_service.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/net/url_util.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/user_metrics.h"
@@ -184,8 +183,7 @@ void ShowSyncSetup(Browser* browser, SyncPromoUI::Source source) {
if (service->HasSyncSetupCompleted()) {
ShowSettings(browser);
} else {
- const bool use_web_flow = CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kUseWebBasedSigninFlow);
+ const bool use_web_flow = OneClickSigninHelper::UseWebBasedSigninFlow();
const bool show_promo =
SyncPromoUI::ShouldShowSyncPromo(browser->profile());

Powered by Google App Engine
This is Rietveld 408576698