Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Side by Side Diff: chrome/common/extensions/api/app_window.idl

Issue 11316292: Add app.window.setIcon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add ExperimentalPlatformAppBrowserTest Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace app.window { 5 namespace app.window {
6 dictionary CreateWindowOptions { 6 dictionary CreateWindowOptions {
7 // Id to identify the window. This will be used to remember the size 7 // Id to identify the window. This will be used to remember the size
8 // and position of the window and restore that geometry when a window 8 // and position of the window and restore that geometry when a window
9 // with the same id (and no explicit size or position) is later opened. 9 // with the same id (and no explicit size or position) is later opened.
10 DOMString? id; 10 DOMString? id;
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 // Show the window. Does nothing if the window is already visible. 115 // Show the window. Does nothing if the window is already visible.
116 static void show(); 116 static void show();
117 117
118 // Hide the window. Does nothing if the window is already hidden. 118 // Hide the window. Does nothing if the window is already hidden.
119 static void hide(); 119 static void hide();
120 120
121 // Set the window's bounds. 121 // Set the window's bounds.
122 static void setBounds(Bounds bounds); 122 static void setBounds(Bounds bounds);
123 123
124 // Set the app icon.
jeremya 2012/12/04 23:56:34 Can you document that this is a) experimental and
stevenjb 2012/12/05 00:56:16 Added experimental, better comment, TODO, and [nod
125 static void setIcon(DOMString icon_url);
126
124 // The JavaScript 'window' object for the created child. 127 // The JavaScript 'window' object for the created child.
125 [instanceOf=global] object contentWindow; 128 [instanceOf=global] object contentWindow;
126 }; 129 };
127 130
128 interface Functions { 131 interface Functions {
129 // The size and position of a window can be specified in a number of 132 // The size and position of a window can be specified in a number of
130 // different ways. The most simple option is not specifying anything at 133 // different ways. The most simple option is not specifying anything at
131 // all, in which case a default size and platform dependent position will 134 // all, in which case a default size and platform dependent position will
132 // be used. 135 // be used.
133 // 136 //
(...skipping 23 matching lines...) Expand all
157 optional CreateWindowCallback callback); 160 optional CreateWindowCallback callback);
158 161
159 // Returns an <a href="#type-AppWindow">AppWindow</a> object for the 162 // Returns an <a href="#type-AppWindow">AppWindow</a> object for the
160 // current script context (ie JavaScript 'window' object). This can also be 163 // current script context (ie JavaScript 'window' object). This can also be
161 // called on a handle to a script context for another page, for example: 164 // called on a handle to a script context for another page, for example:
162 // otherWindow.chrome.app.window.current(). 165 // otherWindow.chrome.app.window.current().
163 [nocompile] static AppWindow current(); 166 [nocompile] static AppWindow current();
164 [nocompile, nodoc] static void initializeAppWindow(object state); 167 [nocompile, nodoc] static void initializeAppWindow(object state);
165 }; 168 };
166 }; 169 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698